FAST: fix KMS delegation role in security stage #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lore, can we explore ways of not having to define a custom role? For keys, having set IAM policy means the ability to self-assign KMS admin, so we might as well use that if we can scope the role to keys via a condition, WDYT? |
|
Cloud KMS Admin scoped on resource type key via a condition should probably get you what you need https://cloud.google.com/iam/docs/conditions-attribute-reference#resource-type |
ludoo
approved these changes
Jun 23, 2022
ludoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom role to let 03 stages (example: 03-data-platform) assign roles on KMS keys